Jun 01, 2016, 8:40 PM
Ext.form.VTypes.Password
The current
In addition, on line 4, Ext.isString(field.initialPassField) will always be true.
Going further,
Is there any chance of it be incorporated into Ext.NET?
Thanks in advance.
Ext.form.VTypes.Password
uses the costly up
and down
functions (line 4), on every call.In addition, on line 4, Ext.isString(field.initialPassField) will always be true.
Going further,
pwd
instance is validated on line 6, then validated again on both line 7 and 10.Ext.apply(Ext.form.VTypes, {
password: function (val, field) {
if (field.initialPassField) {
var pwd = Ext.isString(field.initialPassField) ? (field.up('container') && field.up('container').down('#' + field.initialPassField) || Ext.getCmp(field.initialPassField)) : field.initialPassField;
if (pwd) {
if (pwd.processRawValue) {
return pwd ? (val === pwd.processRawValue(pwd.getRawValue())) : false;
}
else {
return pwd ? (val === pwd.getRawValue()) : false;
}
}
return false;
}
return true;
}
});
So, i would like to suggest the following approach.Ext.apply(Ext.form.VTypes, {
password: function (value, field) {
var initialPassField = field.initialPassField;
if (initialPassField) {
if (Ext.isString(initialPassField)) {
var container = field.up('container');
initialPassField = container && container.down('#' + initialPassField) || Ext.getCmp(field.initialPassField);
field.initialPassField = initialPassField;
}
return initialPassField ? value === (initialPassField.processRawValue ? initialPassField.processRawValue(initialPassField.getRawValue()) : initialPassField.getRawValue()) : false;
}
return true;
}
});
Note: on line 11, field.initialPassField
is set, so on next execution it will not be necessary to "find" initialPassField
again.Is there any chance of it be incorporated into Ext.NET?
Thanks in advance.
Last edited by RaphaelSaldanha; Jun 03, 2016 at 12:04 PM.