[FIXED] [#1398] [4.1.0]Invalid CSS in classic theme

  1. #1

    [FIXED] [#1398] [4.1.0]Invalid CSS in classic theme

    I found some problems in the classic theme css:

    • in this case the url quotes are inside a "content:" and the string is invalid
      .x-cmd-slicer.x-progress-bar-default:before{display:none;content:"x-slicer:, bg:url("http://localhost:2265/extjs/packages/theme_classic/build/resources/images/progress/progress-default-bg-gif/ext.axd"), stretch:bottom" !important}
    • in this snippet there is the invalid char '&', which I think is a missing expansion from SASS sources
      &.x-treelist-highlight-path .x-treelist-item-over > * > .x-treelist-item-icon{color:gray;transition:color 0.5s}&.x-treelist-highlight-path .x-treelist-item-over > * > .x-treelist-item-text{color:#000;transition:color 0.5s}&.x-treelist-highlight-path
      this seems present in the original files form extjs

    I'm using RequestReduce that internally uses AjaxMin. The first problem is more serious, as it completely breaks the theme. At the moment i circumvented it modifying RequestReduce sources with a regex to substitute url(" ") with url(' ').
    Last edited by fabricio.murta; Jan 15, 2017 at 1:59 AM.
  2. #2
    Hello @moldeveloper! Thanks for the report!

    As for the first CSS it is a problem specific to Ext.NET but as for the second one as you suggested, I also noticed it is coming from ExtJS's prebuilt commercial package from different version, so maybe there's a reason they are starting with ampersand. I don't really get an error on my browser while loading the CSS files, but it really looks odd. It will require a look on the origin SCSS files to double check what is that coming from.

    As for the second CSS it is a problem while generating the CSS files with embedded resource paths. We've created an issue under #1398 to fix this problem.

    As you pointed the fixes are pretty easy to make, but we'd better fix it so the next versions do not redo this bug, so this could take some more effort to be fixed for good, thus the issue is very relevant.

    I wonder why not using RequestReduce you told about does not break the theme at all.
    Fabrício Murta
    Developer & Support Expert
  3. #3

    We've just fixed issue #1398 which was related to the worst part of the report you provided!

    We have just logged the second part (strange ampersand in rule) and reported it in Sencha (all details in #1412). In case you want a feedback about this issue and can't track/follow the github issue, please open a new forum thread so we can bind it to that issue.

    Thanks for reporting the issue!
    Fabrício Murta
    Developer & Support Expert

Similar Threads

  1. Replies: 1
    Last Post: Mar 04, 2015, 7:04 PM
  2. Replies: 0
    Last Post: Mar 06, 2014, 4:20 AM
  3. [CLOSED] [#107] Problem with Slate Theme
    By Daly_AF in forum 2.x Legacy Premium Help
    Replies: 3
    Last Post: Dec 29, 2012, 8:08 AM
  4. [CLOSED] Slate Theme - Invalid web resource request error
    By vali1993 in forum 1.x Legacy Premium Help
    Replies: 13
    Last Post: Oct 20, 2011, 11:30 AM
  5. [OPEN] Invalid Label Error
    By josmar52789 in forum Bugs
    Replies: 5
    Last Post: Jan 14, 2009, 12:53 PM

Tags for this Thread

Posting Permissions