[FIXED] [#1206] [3.3] TagField control getValue() issue when adding custom values

[adrianot]

Hi Daniil/Fabricio,
we applied the patch by merging the SVN changeset but it looks like that only pressing "ENTER" is now fine whereas pressing "TAB" after manually inserting a new item on the tagfileld produces strange issues:

1) Trying using ONLY THE "TAB" key, "getValue()" still returns a single item (wrong).

2) Trying both ENTER and then TAB it throws an error on the client that breaks the layout (meaning that the app is not usable anymore).
"cannot read property 'internalId' of undefined."

Thank you for hlep,
Cheers

[Daniil]

Thank you for the feedback! I'll investigate the issues that you've reported.

[adrianot]

Hi Fabricio/Daniil,

We had chance to update Ext.Net 3.x to the latest SVN release, but the issue still persists (I mean that getValue() retrieves wrong items when using the "tab" key to insert new tag values).

Cheers

[Daniil]

Hello Adriano,

Thank you very much for the feedback!

I apologize for the delay in fixing that - so many things were being done with Ext.NET v4. I will get this task higher in my TODO list.

[adrianot]

Thank you Daniil!

[Daniil]

Created an Issue:
https://github.com/extnet/Ext.NET/issues/1278

Fixed in both - v3 and v4.

While it is fixed in the sources, here is an override to test it quickly if you want.

Fix

Ext.net.TagField.override({
    assertValue: function () {
        var me = this,
            value = me.inputEl ? me.inputEl.dom.value : "",
            rec;

        if (me.createNewOnBlur && value) {
            if (me.encodeOnCreate) {
                value = Ext.String.htmlEncode(value);
            }

            rec = me.findRecordByDisplay(value);
            this.creatingOnBlur = true;
            me.store.clearFilter(); // #1278

            if (rec) {
                this.addTagToInput(rec);
            }
            else if (!me.forceSelection) {
                this.addTagToInput({ text: value, value: value });
            }
            this.creatingOnBlur = false;
        }

        me.inputEl.dom.value = '';
        if (this.tagLabel) {
            Ext.defer(function () {
                this.tagLabel.ulEl.appendChild(this.tagLabel.inputLi);
            }, 1, this);
        }
        me.collapse();
    }
});