[FIXED] [#659] MultiUpload unhandled exception when hover over "Browse..." button (SVN 6281)

Page 1 of 2 12 LastLast
  1. #1

    [FIXED] [#659] MultiUpload unhandled exception when hover over "Browse..." button (SVN 6281)

    Hi,

    In the example http://examples.ext.net/Examples/Mul...ad/Basic/Grid/ when you hover mouse cursor over the Browse button, unhanded exception is thrown.



    The exception is thrown in function "is" of Ext.dom.Element.

     is: function(selector) {
              var dom = this.dom,
                    is;
                if (!selector) {                              
                    is = true;
                } else if (!dom.tagName) {
                    
                    is = false;
                } else if (Ext.isFunction(selector)) {
                    is = selector(dom);
                } else {
                    // EXCEPTION IS THROWN HERE...
                    is = dom[Ext.supports.matchesSelector](selector);
                }
                return is;
            }


    Below is my workaround for this problem but I think it might not be the real nature of the problem.

    Ext.define("App.Patches.dom.Element", {
    
                override: 'Ext.dom.Element',
    
                is: function (selector) {
                    var dom = this.dom,
                        is;
                    if (!selector) {
    
                        is = true;
                    } else if (!dom.tagName) {
    
                        is = false;
                    } else if (Ext.isFunction(selector)) {
                        is = selector(dom);
                    } else {
                                            // WORKAROUND / FIX
                        if (dom[Ext.supports.matchesSelector]) {
                            is = dom[Ext.supports.matchesSelector](selector);
                        }
                        else {
                            is = false;
                        }
                        
                    }
                    return is;
                }
            });
    Attached Thumbnails multiupload_unhandled_exception.png  
    Last edited by Daniil; Mar 03, 2015 at 8:47 AM. Reason: [FIXED] [#659]
  2. #2
    Hi Matt,

    Thank you for the report.

    Your workaround is good enough for now to move on, but the real problem is that IE seems don't support .msMatchesSelector() for an <object>. At least, for a Flash <object>. I am looking for a way to check an <object> on selector. I will check jQuery. Maybe, this problem is solved there.
    Last edited by Daniil; Jan 28, 2015 at 7:41 AM.
  3. #3
    Created an Issue.
    https://github.com/extnet/Ext.NET/issues/659

    Yes, jQuery helped to fix the defect. Committed the fix in the revision #6282. It goes to 3.1.0 beta release.
  4. #4
    Thank you

    I confirm. It is working fine now.
  5. #5
    Hi Matt,

    For some reason we've removed the fix from SVN. Maybe, it was removed by mistake, but it is another story. Currently, I am trying to reproduce the original issue and somehow I cannot reproduce it. Could you, please, do a favor updating from SVN trunk and retest the issue? Is it reproducible or not for you?
    Last edited by Daniil; Mar 02, 2015 at 6:35 AM.
  6. #6
    Hi Danill,

    Yes, the problem is reproducible in latest SVN. Thank you for letting me know... for the time being I will patch it again.
  7. #7
    Thank you for a quick answer. I cannot understand why I cannot reproduce it on my side. After your initial bug report I reproduced it easily with just this test case. Can you reproduce it with this test case?

    Also my environment is still the same - Windows 7 and IE 10. Maybe, some recent Windows Update fixed it... Do you have all the Windows Updates installed currently? Only IE 11 is not installed for me. But again, I was able to reproduce it easily with IE 10.

    Example
    <%@ Page Language="C#" %>
    
    <!DOCTYPE html>
    <html>
    <head runat="server">
        <title>Ext.NET v3 Example</title>
    </head>
    <body>
        <form runat="server">
            <ext:ResourceManager runat="server" />
    
            <ext:MultiUpload runat="server" />
        </form>
    </body>
    </html>
  8. #8
    Hi Danill,

    There is one more "odd" thing going on right now. I am trying to apply the patch. It does override "is" method but it doesn't fix the problem now. For some reason the non-overridden "is" is called.

    Have a look at the stack trace...

    In both cases the patch is applied and item selector in findParent is the same: #pv_pltUpload .x-resizable-handle

    Case 1: the patch version is called

    Click image for larger version. 

Name:	patch call.png 
Views:	2 
Size:	45.9 KB 
ID:	21971


    Case 2: original version is called (so patch doesn't help here)

    Click image for larger version. 

Name:	original call.png 
Views:	2 
Size:	46.6 KB 
ID:	21972

    Hope this will help. I will try to carve out simple version of my code and post it here...

    Best,
  9. #9
    I would also expect the original .is() should not be called. Yeah, I would love to investigate a test case.
  10. #10
    Danill,

    I've got prebeta-release tomorrow. Can you tell me in which version it was removed so I can go back to the previous ?
    I will try to prepare test case now.

    Thank you,
Page 1 of 2 12 LastLast

Similar Threads

  1. Replies: 8
    Last Post: Jan 31, 2015, 6:08 AM
  2. Replies: 0
    Last Post: Jan 24, 2014, 4:57 PM
  3. Replies: 3
    Last Post: May 14, 2013, 12:34 AM
  4. Replies: 7
    Last Post: Dec 19, 2012, 3:02 PM
  5. Replies: 2
    Last Post: May 03, 2012, 3:12 PM

Tags for this Thread

Posting Permissions