What's New?

[FIXED] [2.5.1] Grouping Grid expand/collapse error

  1. #1
    Mar 05, 2014, 11:57 AM

    [FIXED] [2.5.1] Grouping Grid expand/collapse error

    Hi,

    After clicked a row to expand/collapse on a Grouped Grid, throws javascript errors behind, bu it seems to work functionally. (Ext.Net v.2.5.0)

    https://examples2.ext.net/#/GridPane...eous/Grouping/

    node parameter undefined

    Ext.view.Table.override({
  //...
    indexInStore: function (node) {
      
        node = node.isCollapsedPlaceholder ? this.getNode(node) : this.getNode(node, false);
        if (!node && node !== 0) {
            return -1;
        }
        var recordIndex = node.getAttribute('data-recordIndex');
        if (recordIndex) {
            return parseInt(recordIndex, 10);
        }
        return this.dataSource.indexOf(this.getRecord(node));
    },
   
});
    Last edited by Daniil; Mar 06, 2014 at 5:37 AM. Reason: [FIXED] [2.5.1]
  2. #2
    Mar 06, 2014, 3:30 AM
    Hi @bilbey,

    Thank you for the report. We are investigating.
  3. #3
    Mar 06, 2014, 5:25 AM
    It has been fixed in the revision #5712. It will go to the next release.

    We might need to release v2.5.1 because of this issue. It is not reproducible with v2.4, so, has been introduced in v2.5. It is quite severe, because, as far as I can understand, it causes a JavaScript error for any Grouping case if collapse a group. Added to the Agenda for our next team meeting on March 11.

    Here is a related Issue.
    https://github.com/extnet/Ext.NET/issues/264
    Last edited by Daniil; Mar 06, 2014 at 5:43 AM.
  4. #4
    Mar 06, 2014, 5:42 AM
    Due to your report we caught another bug which is reproducible since v2.3.
    http://forums.ext.net/showthread.php?28531
  5. #5
    Mar 07, 2014, 7:48 AM
    It can be fixed without updating from SVN by adding the following override into the page's <head>.

    Fix
    Ext.view.Table.override({
    indexInStore: function(node) {
        node = (node && node.isCollapsedPlaceholder) ? this.getNode(node) : this.getNode(node, false);

        if (!node && node !== 0) {
            return -1;
        }

        var recordIndex = node.getAttribute('data-recordIndex');

        if (recordIndex) {
            return parseInt(recordIndex, 10);
        }

        return this.dataSource.indexOf(this.getRecord(node));
    }
});
  6. #6
    Mar 07, 2014, 8:32 AM
    Thanks! I have used similar fix.

    Quote Originally Posted by Daniil View Post
    It can be fixed without updating from SVN by adding the following override into the page's <head>.

    Fix
    Ext.view.Table.override({
    indexInStore: function(node) {
        node = (node && node.isCollapsedPlaceholder) ? this.getNode(node) : this.getNode(node, false);

        if (!node && node !== 0) {
            return -1;
        }

        var recordIndex = node.getAttribute('data-recordIndex');

        if (recordIndex) {
            return parseInt(recordIndex, 10);
        }

        return this.dataSource.indexOf(this.getRecord(node));
    }
});
  7. #7
    Mar 24, 2014, 11:13 PM
    This a serious bug for us. We get the Javascript crash on almost all our grids. We get it with a mouse over or mouse out event.

    Is there a way to make the fix available to the entire app?
  8. #8
    Mar 25, 2014, 6:21 AM
    Quote Originally Posted by Arbee View Post
    Is there a way to make the fix available to the entire app?
    Only applying the fix on each page.

    This week we are going to release v2.5.1. It will contain this fix.

Similar Threads

  1. [CLOSED] [2.1] Grid Grouping - Expand/Collapse does not react on the first call, StartCollapsed ignored
    By blueworld in forum 2.x Legacy Premium Help
    Replies: 1
    Last Post: Feb 08, 2013, 11:25 AM
  2. Error with Scroll when I Collapse or Expand the panel
    By delta in forum 2.x Help
    Replies: 0
    Last Post: Nov 03, 2012, 7:19 AM
  3. [CLOSED] Expand / Collapse Grid group in client side - Razor
    By MTSI in forum 2.x Legacy Premium Help
    Replies: 8
    Last Post: Aug 31, 2012, 12:52 PM
  4. grid grouping prevent collapse
    By [WP]joju in forum 1.x Help
    Replies: 4
    Last Post: Jan 18, 2010, 1:03 AM
  5. [FIXED] [V0.8.2] Fieldset javascript error calling expand() or collapse() in code behind
    By clanger in forum Bugs
    Replies: 4
    Last Post: Aug 19, 2009, 2:01 PM

Tags for this Thread

Posting Permissions