[CLOSED] Grid rowbody feature

[RRD]

Hi.
I am using grid with RowBody feature and GetAdditionalData function.

function GetAdditionalDataFn(record, rowIndex, rowValues) {
    var headerCt = this.view.headerCt,
            colspan = headerCt.getColumnCount();    
    var body = "";
    if (rowIndex === index2)
        body = html2;
    return {
        rowBody: body,
        rowBodyCls: this.rowBodyCls,
        rowBodyColspan: colspan
    };
}

This code calls 4 times and insert the same data 2 times. Why the same data inserted 2 times?

[Vladimir]

Please provide simple runable test case

[RRD]

using System;

namespace Ext.Net.Examples
{
    public partial class IncorrectExpanderHeight : System.Web.UI.Page
    {
        protected void Page_Load(object sender, EventArgs e)
        {
            const string desc = "this.desc_data = \"Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Sed metus nibh, sodales a, porta at, " +
                               "vulputate eget, dui. Pellentesque ut nisl. Maecenas tortor turpis, interdum non, sodales non, " +
                               "iaculis ac, lacus. Vestibulum auctor, tortor quis iaculis malesuada, libero lectus bibendum purus, " +
                               "sit amet tincidunt quam turpis vel lacus. In pellentesque nisl non sem. Suspendisse nunc sem, " +
                               "pretium eget, cursus a, fringilla vel, urna.<br/><br/>Aliquam commodo ullamcorper erat. " +
                               "Nullam vel justo in neque porttitor laoreet. Aenean lacus dui, consequat eu, adipiscing eget, " +
                               "nonummy non, nisi. Morbi nunc est, dignissim non, ornare sed, luctus eu, massa. Vivamus eget quam. " +
                               "Vivamus tincidunt diam nec urna. Curabitur velit.\";";

            this.Store1.DataSource = new object[]
            {
                new object[] { "3m Co", 71.72, 0.02, 0.03, "9/1 12:00am", "Manufacturing", desc },
                new object[] { "Alcoa Inc", 29.01, 0.42, 1.47, "9/1 12:00am", "Manufacturing", desc },
                new object[] { "Altria Group Inc", 83.81, 0.28, 0.34, "9/1 12:00am", "Manufacturing", desc },
                new object[] { "American Express Company", 52.55, 0.01, 0.02, "9/1 12:00am", "Finance", desc },
                new object[] { "American International Group, Inc.", 64.13, 0.31, 0.49, "9/1 12:00am", "Services", desc },
                new object[] { "AT&T Inc.", 31.61, -0.48, -1.54, "9/1 12:00am", "Services", desc },
                new object[] { "Boeing Co.", 75.43, 0.53, 0.71, "9/1 12:00am", "Manufacturing", desc },
                new object[] { "Caterpillar Inc.", 67.27, 0.92, 1.39, "9/1 12:00am", "Services", desc },
                new object[] { "Citigroup, Inc.", 49.37, 0.02, 0.04, "9/1 12:00am", "Finance", desc },
                new object[] { "E.I. du Pont de Nemours and Company", 40.48, 0.51, 1.28, "9/1 12:00am", "Manufacturing", desc },
                new object[] { "Exxon Mobil Corp", 68.1, -0.43, -0.64, "9/1 12:00am", "Manufacturing", desc },
                new object[] { "General Electric Company", 34.14, -0.08, -0.23, "9/1 12:00am", "Manufacturing", desc },
                new object[] { "General Motors Corporation", 30.27, 1.09, 3.74, "9/1 12:00am", "Automotive", desc },
                new object[] { "Hewlett-Packard Co.", 36.53, -0.03, -0.08, "9/1 12:00am", "Computer", desc },
                new object[] { "Honeywell Intl Inc", 38.77, 0.05, 0.13, "9/1 12:00am", "Manufacturing", desc },
                new object[] { "Intel Corporation", 19.88, 0.31, 1.58, "9/1 12:00am", "Computer", desc },
                new object[] { "International Business Machines", 81.41, 0.44, 0.54, "9/1 12:00am", "Computer", desc },
                new object[] { "Johnson & Johnson", 64.72, 0.06, 0.09, "9/1 12:00am", "Medical", desc },
                new object[] { "JP Morgan & Chase & Co", 45.73, 0.07, 0.15, "9/1 12:00am", "Finance", desc },
                new object[] { "McDonald\"s Corporation", 36.76, 0.86, 2.40, "9/1 12:00am", "Food", desc },
                new object[] { "Merck & Co., Inc.", 40.96, 0.41, 1.01, "9/1 12:00am", "Medical", desc },
                new object[] { "Microsoft Corporation", 25.84, 0.14, 0.54, "9/1 12:00am", "Computer", desc },
                new object[] { "Pfizer Inc", 27.96, 0.4, 1.45, "9/1 12:00am", "Medical", desc },
                new object[] { "The Coca-Cola Company", 45.07, 0.26, 0.58, "9/1 12:00am", "Food", desc },
                new object[] { "The Home Depot, Inc.", 34.64, 0.35, 1.02, "9/1 12:00am", "Retail", desc },
                new object[] { "The Procter & Gamble Company", 61.91, 0.01, 0.02, "9/1 12:00am", "Manufacturing", desc },
                new object[] { "United Technologies Corporation", 63.26, 0.55, 0.88, "9/1 12:00am", "Computer", desc },
                new object[] { "Verizon Communications", 35.57, 0.39, 1.11, "9/1 12:00am", "Services", desc },
                new object[] { "Wal-Mart Stores, Inc.", 45.45, 0.73, 1.63, "9/1 12:00am", "Retail", desc }
            };
            var commandColumn = new CommandColumn { Sortable = false, MenuDisabled = true, Draggable = false, DataIndex = "ExpandCollapseCommentRows", Width = 35 };

            var gridCommand = new GridCommand { CommandName = "ExpandCollapse" };

            commandColumn.Commands.Add(gridCommand);
            commandColumn.Listeners.Command.Fn = "ExpandCollapseRowFn";
            //commandColumn.PrepareToolbar.Fn = "PrepareToolbarFn";
            GridPanel1.ColumnModel.Columns.Add(commandColumn);
            this.Store1.DataBind();

            string dataID = string.Concat(this.Store1.ClientID, ".proxy.data");
            string push = string.Format(@"for (var i = 0; i < {0}.length; i++) {{{0}[i].push(desc_data);}}", dataID);

            this.ResourceManager1.RegisterClientScriptBlock("desc_data", desc);
            this.ResourceManager1.RegisterOnReadyScript(push);
        }
    }
}

<%@ Page Language="C#" AutoEventWireup="true" CodeBehind="IncorrectExpanderHeight.aspx.cs" Inherits="Ext.Net.Examples.IncorrectExpanderHeight" %>

<!DOCTYPE html>

<html xmlns="http://www.w3.org/1999/xhtml">
<head id="Head1" runat="server">
    <title>GridPanel with RowExpander Plugin - Ext.NET Examples</title>    
    <style>        
        .x-grid-cell-inner
        {
            white-space: normal;
        }
    </style>
    <script>
        var template = '<span style="color:{0};">{1}</span>';

        var change = function (value) {
            return Ext.String.format(template, (value > 0) ? "green" : "red", value);
        };
        var pctChange = function (value) {
            return Ext.String.format(template, (value > 0) ? "green" : "red", value + "%");
        };

        var expandRowFn = function (rowNode, record, expandRow, index) {
            var html = "this.desc_data = \"Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Sed metus nibh, sodales a, porta at, " +
                               "vulputate eget, dui. Pellentesque ut nisl. Maecenas tortor turpis, interdum non, sodales non, " +
                               "iaculis ac, lacus. Vestibulum auctor, tortor quis iaculis malesuada, libero lectus bibendum purus, " +
                               "sit amet tincidunt quam turpis vel lacus. In pellentesque nisl non sem. Suspendisse nunc sem, " +
                               "pretium eget, cursus a, fringilla vel, urna.<br/><br/>Aliquam commodo ullamcorper erat. " +
                               "Nullam vel justo in neque porttitor laoreet. Aenean lacus dui, consequat eu, adipiscing eget, " +
                               "nonummy non, nisi. Morbi nunc est, dignissim non, ornare sed, luctus eu, massa. Vivamus eget quam. " +
                               "Vivamus tincidunt diam nec urna. Curabitur velit.\";";
            Ext.get(expandRow).setHTML(html);
        };
        
        function ExpandCollapseRowFn(column, commandName, record, rowIndex) {
            if (commandName === "ExpandCollapse") {
                var grid = App.GridPanel1,
                    rowExpander = grid.getRowExpander();

                rowExpander.toggleRow(rowIndex, record);
                record.data.iconCls = rowExpander.isExpanded(rowIndex) ? "hasComment" : "";                
            }
        };

        function GetAdditionalDataFn(record, rowIndex, rowValues) {
            var headerCt = this.view.headerCt,
			colspan = headerCt.getColumnCount();
            var body = "";
            if (rowIndex === 5)
                body = "<div>This is div</div>";            
            return {
                rowBody: body,
                rowBodyCls: this.rowBodyCls,
                rowBodyColspan: colspan
            };
        }

        GetAdditionalDataFn
    </script>
</head>
<body>
    <form id="Form1" runat="server">        
        <ext:ResourceManager ID="ResourceManager1" runat="server" />

        <h1>GridPanel with RowExpander Plugin</h1>

        <ext:GridPanel
            ID="GridPanel1"
            runat="server"
            ShrinkWrap="Both"
            Title="RowExpander"
            Collapsible="true"
            AnimCollapse="true"
            Icon="Table"
            Width="1200"
            Height="900">
            <Store>
                <ext:Store ID="Store1" runat="server">
                    <Model>
                        <ext:Model ID="Model1" runat="server">
                            <Fields>
                                <ext:ModelField Name="company" />
                                <ext:ModelField Name="price" Type="Float" />
                                <ext:ModelField Name="change" Type="Float" />
                                <ext:ModelField Name="pctChange" Type="Float" />
                                <ext:ModelField Name="lastChange" Type="Date" DateFormat="M/d hh:mmtt" />
                                <ext:ModelField Name="industry" />                                
                            </Fields>
                        </ext:Model>
                    </Model>
                </ext:Store>
            </Store>
            <ColumnModel ID="ColumnModel1" runat="server">
                <Columns>
                    <ext:Column ID="Column1" runat="server" Text="Company" DataIndex="company" Flex="1" />
                    <ext:Column ID="Column2" runat="server" Text="Price" DataIndex="price">
                        <Renderer Format="UsMoney" />
                    </ext:Column>
                    <ext:Column ID="Column3" runat="server" Text="Change" DataIndex="change">
                        <Renderer Fn="change" />
                    </ext:Column>
                    <ext:Column ID="Column4" runat="server" Text="Change" DataIndex="pctChange">
                        <Renderer Fn="pctChange" />
                    </ext:Column>
                    <ext:DateColumn ID="DateColumn1" runat="server" Text="Last Updated" DataIndex="lastChange" />                    
                </Columns>
            </ColumnModel>
            <Features>
                <ext:RowBody runat="server">
                    <GetAdditionalData Fn="GetAdditionalDataFn"/>
                </ext:RowBody>
            </Features>
            <View>
                <ext:GridView ID="GridView1" runat="server" />
            </View>
            <SelectionModel>
                <ext:RowSelectionModel ID="RowSelectionModel1" runat="server" Mode="Multi" />
            </SelectionModel>
            <Plugins>
                <ext:RowExpander ID="RowExpander1" runat="server">
                    <Listeners>
                        <Expand Fn="expandRowFn"></Expand>
                    </Listeners>                    
                </ext:RowExpander>
            </Plugins>
        </ext:GridPanel>
    </form>
</body>
</html>

[Daniil]

Hi @RRD,

RowExpander uses RowBody internally. So, with your RowBody in the GridPanel's Features, there are two RowBodies in the GridPanel. I think it is not supposed to happen. I mean that there must be a single RowBody feature. You should refuse from either RowExpander or RowBody.

[RRD]

I need RowExpander and I need to add data with colspan. How can I implement it?

[RRD]

I think it's a bug with 2 data inserted because if I expand and collapse row then only one data left inserted.

[Daniil]

I am afraid it cannot be considered as a bug since these things - RowExpander and RowBody - cannot be used at the same time.

[RRD]

How can I add data to grid with colspan without using RowBody and without removing RowExpander?

[Daniil]

I would try to override a RowExpander's getRowBodyFeatureData. The original code is:

getRowBodyFeatureData: function(record, idx, rowValues) {
    var me = this;
    me.self.prototype.setupRowData.apply(me, arguments);

    rowValues.rowBody = me.getRowBodyContents(record);
    rowValues.rowBodyCls = me.recordsExpanded[record.internalId] ? '' : me.rowBodyHiddenCls;
}

For example, this override:

Ext.ux.RowExpander.override({
    getRowBodyFeatureData: function(record, idx, rowValues) {
        var me = this;
                
        me.self.prototype.setupRowData.apply(me, arguments);
        rowValues.rowBody = me.getRowBodyContents(record);

        if (idx === 0) {
            rowValues.rowBody = "<div>This is div</div>";
             rowValues.rowBodyCls = '';
        } else {
            rowValues.rowBodyCls = me.recordsExpanded[record.internalId] ? '' : me.rowBodyHiddenCls;
        }
    }
});

Please note that with your scenario this

<div>This is div</div>

will be erased since you are doing this on row expand:

Ext.get(expandRow).setHTML(html);

You might need to restore that on row collapse. I am not sure what exactly you need.

[RRD]

In what place do I need to put this code? I try to use Ext.onReady and Grid storeLoad and it doesn't call.