[CLOSED] Could not insert column in gridpanel after setting EnableLocking (true)

  1. #1

    [CLOSED] Could not insert column in gridpanel after setting EnableLocking (true)

    Hi,
    I am using Ext.net gridpanel and I have set EnableLocking(true) to gridpanel to lock column in javascript.
    I am doing reordering of columns in gridpanel. For that I am inserting columns in gridpanel with new column index.
    If I remove EnableLocking(true) from gridpanel then column reorders as per new column index coming from database
    but here I could not lock the column in javascript. After adding EnableLocking(true) column reordering doesn't happens.

    View:
    @model object[]
    @{
        ViewBag.Title = "Simple Array Grid - Ext.NET MVC Examples";
        Layout = null;
    }
        <style>
            .x-grid-row-over .x-grid-cell-inner {
                font-weight : bold;
            }
        </style>
    
        <script>
            var template = '<span style="color:{0};">{1}</span>';
    
            var change = function (value) {
                return Ext.String.format(template, (value > 0) ? "green" : "red", value);
            };
    
            var pctChange = function (value) {
                return Ext.String.format(template, (value > 0) ? "green" : "red", value + "%");
            };
    
            var onComboBoxSelect = function (combo) {
                var store = combo.up("gridpanel").getStore();
    
                store.pageSize = parseInt(combo.getValue(), 10);
                store.load();
            };
    
            var reorderColumns = function (store, records) {                                  
                var vColumns = App.grid.view.getGridColumns();           
                Ext.each(vColumns, function (col) {
                    Ext.each(records, function (rec) {                   
                        if (col.text == rec.data.ColumnName) {
                            if (rec.data.Locked) {
                                App.grid.lock(col);
                            }
                            App.grid.insertColumn(rec.data.Order, col, true);
                        }
                    });
                });            
            };               
    
        </script>  
    <div>
        <h1>Simple Array Grid</h1>
    @(Html.X().ResourceManager(ViewBag.ManagerConfig as MvcResourceManagerConfig))
        @(Html.X().Store().ID("storeForEditColumns")        
            .Model(Html.X().Model()        
            .Fields(            
                        new ModelField("ColumnName", ModelFieldType.String),
                        new ModelField("Display", ModelFieldType.Boolean),
                        new ModelField("Locked", ModelFieldType.Boolean),
                        new ModelField("Order", ModelFieldType.Int)                            
                    )
            ).DataSource(Model[1]).Listeners(l => l.Load.Fn = "reorderColumns"))
            
        @(Html.X().GridPanel()
        .ID("grid")
            .Title("Array Grid")
            .Width(600)
            .EnableLocking(true)
            .Height(350)        
            .Store(Html.X().Store()
            .ID("Store")        
                    .PageSize(10)                
                .Model(Html.X().Model()
                    .Fields(
                        new ModelField("company"),
                        new ModelField("price", ModelFieldType.Float),
                        new ModelField("change", ModelFieldType.Float),
                        new ModelField("pctChange", ModelFieldType.Float),
                        new ModelField("lastChange", ModelFieldType.Date, "M/d hh:mmtt")
                    )
                )
                .DataSource(Model[0])
            )
            .ColumnModel(
                Html.X().Column().Text("company").DataIndex("company"),
                Html.X().Column().Text("Price").DataIndex("price").Renderer(RendererFormat.UsMoney),
                Html.X().Column().Text("change").DataIndex("change").Renderer("change"),
                Html.X().Column().Text("pctChange").DataIndex("pctChange").Renderer("pctChange"),
                Html.X().DateColumn().Text("lastChange").DataIndex("lastChange")
            )
            .BottomBar(
                Html.X().PagingToolbar()
                    .Items(
                        Html.X().Label("Page size:"),
                        Html.X().ToolbarSpacer(10),
                        Html.X().ComboBox()
                            .Width(80)
                            .Items("1", "2", "10", "20")
                            .SelectedItems("10")
                            .Listeners(l=>{
                                l.Select.Fn = "onComboBoxSelect";
                            })
                    )                
                    .Plugins(Html.X().ProgressBarPager())
            )             
        )
        </div>
    Controller:
            public ActionResult pagingDemo()
            {
                return View(Companies.GetAllCompanies());
            }
    
    public class Companies
        {
            public static System.Collections.IEnumerable GetAllCompanies()
            {
                object[] lstData = new object[]
                    {
                        new object[] { "3m Co", 71.72, 0.02, 0.03, "9/1 12:00am" },
                        new object[] { "Alcoa Inc", 29.01, 0.42, 1.47, "9/1 12:00am" },
                        new object[] { "Altria Group Inc", 83.81, 0.28, 0.34, "9/1 12:00am" },
                        new object[] { "American Express Company", 52.55, 0.01, 0.02, "9/1 12:00am" },
                        new object[] { "American International Group, Inc.", 64.13, 0.31, 0.49, "9/1 12:00am" },
                        new object[] { "AT&T Inc.", 31.61, -0.48, -1.54, "9/1 12:00am" },
                        new object[] { "Boeing Co.", 75.43, 0.53, 0.71, "9/1 12:00am" },
                        new object[] { "Caterpillar Inc.", 67.27, 0.92, 1.39, "9/1 12:00am" },
                        new object[] { "Citigroup, Inc.", 49.37, 0.02, 0.04, "9/1 12:00am" },
                        new object[] { "E.I. du Pont de Nemours and Company", 40.48, 0.51, 1.28, "9/1 12:00am" },
                        new object[] { "Exxon Mobil Corp", 68.1, -0.43, -0.64, "9/1 12:00am" },
                        new object[] { "General Electric Company", 34.14, -0.08, -0.23, "9/1 12:00am" },
                        new object[] { "General Motors Corporation", 30.27, 1.09, 3.74, "9/1 12:00am" },
                        new object[] { "Hewlett-Packard Co.", 36.53, -0.03, -0.08, "9/1 12:00am" },
                        new object[] { "Honeywell Intl Inc", 38.77, 0.05, 0.13, "9/1 12:00am" },
                        new object[] { "Intel Corporation", 19.88, 0.31, 1.58, "9/1 12:00am" },
                        new object[] { "International Business Machines", 81.41, 0.44, 0.54, "9/1 12:00am" },
                        new object[] { "Johnson & Johnson", 64.72, 0.06, 0.09, "9/1 12:00am" },
                        new object[] { "JP Morgan & Chase & Co", 45.73, 0.07, 0.15, "9/1 12:00am" },
                        new object[] { "McDonald\"s Corporation", 36.76, 0.86, 2.40, "9/1 12:00am" },
                        new object[] { "Merck & Co., Inc.", 40.96, 0.41, 1.01, "9/1 12:00am" },
                        new object[] { "Microsoft Corporation", 25.84, 0.14, 0.54, "9/1 12:00am" },
                        new object[] { "Pfizer Inc", 27.96, 0.4, 1.45, "9/1 12:00am" },
                        new object[] { "The Coca-Cola Company", 45.07, 0.26, 0.58, "9/1 12:00am" },
                        new object[] { "The Home Depot, Inc.", 34.64, 0.35, 1.02, "9/1 12:00am" },
                        new object[] { "The Procter & Gamble Company", 61.91, 0.01, 0.02, "9/1 12:00am" },
                        new object[] { "United Technologies Corporation", 63.26, 0.55, 0.88, "9/1 12:00am" },
                        new object[] { "Verizon Communications", 35.57, 0.39, 1.11, "9/1 12:00am" },
                        new object[] { "Wal-Mart Stores, Inc.", 45.45, 0.73, 1.63, "9/1 12:00am" }
                    };
    
                object[] lstColumnsData = new object[]
                    {
                        new ColumnsDTO(){ ColumnName="company", Display= true,Locked= false,Order=3 },
                        new ColumnsDTO() { ColumnName="price", Display=true,Locked= false,Order=2 },
                        new ColumnsDTO() { ColumnName="change",Display= true, Locked= false,Order=1 },
                        new ColumnsDTO() { ColumnName="pctChange", Display=true, Locked= false,Order=4 },
                        new ColumnsDTO() { ColumnName="lastChange", Display=true,Locked=  false,Order=5 }                      
                    };
    
                    return new object[] { lstData,lstColumnsData };
            }
        }
    
        public class ColumnsDTO 
        {
            [DataMember]
            public string ColumnName { get; set; }
    
            [DataMember]
            public bool Display { get; set; }
    
            [DataMember]
            public bool Locked { get; set; }       
    
            [DataMember]       
            public int Order { get; set; }
        }
    Please provide us solution.
    Thanks
    Last edited by Daniil; Apr 26, 2013 at 1:39 PM. Reason: [CLOSED]
  2. #2
    Hi @alscg,

    I think there is a bug.

    Please try the following fix for now.

    Fix
    Ext.grid.Panel.override({
        insertColumn: function (index, newCol, doLayout) {
            var headerCt = this.normalGrid ? this.normalGrid.headerCt : this.headerCt;
    
            if (index < 0) {
                index = 0;
            }
    
            if (newCol.locked && this.lockedGrid) {
                headerCt = this.lockedGrid.headerCt;
            }
    
            headerCt.insert(index, newCol);
    
            if (doLayout !== false) {
                this.updateLayout();
                this.fireEvent('reconfigure', this);
                this.getView().refresh();
            }
        }
    });
  3. #3
    Thanks for your quick reply.

    I have added code on my page and now I am able to change the order of columns in javascript.
    However, some columns are not displaying as per their order/index after inserting into gridpanel.
    For example: 'price' column is not displaying at position as per it's assigned column index.
    I have modified javascript as
     Ext.grid.Panel.override({
                insertColumn: function (index, newCol, doLayout) {
                    var headerCt = this.normalGrid ? this.normalGrid.headerCt : this.headerCt;
    
                    if (index < 0) {
                        index = 0;
                    }
    
                    if (newCol.locked && this.lockedGrid) {
                        headerCt = this.lockedGrid.headerCt;
                    }
    
                    headerCt.insert(index, newCol);
    
                    if (doLayout !== false) {
                        this.updateLayout();
                        this.fireEvent('reconfigure', this);
                        this.getView().refresh();
                    }
                }
            });
    
    var reorderColumns = function (store, records) {
                var recs = [];
                Ext.each(records, function (rec) {
                    recs.push({ "ColumnName": rec.data.ColumnName, "Order": rec.data.Order,"Locked":rec.data.Locked });
                });
    
                var vColumns = App.grid.view.getGridColumns();            
                Ext.each(vColumns, function (col) {
                    var found = $.map(recs, function (item) {
                        if (item.ColumnName == col.text) {
                            return parseInt(item.Order);
                        }
                    });    
                    App.grid.lock(col);             
                    App.grid.insertColumn(parseInt(found) - 1, col, true);                              
                });            
            };
    Modification in 'Companies' class in controller
    public class Companies
        {
            public static System.Collections.IEnumerable GetAllCompanies()
            {
                object[] lstData = new object[]
                    {
                        new object[] { "3m Co", 71.72, 0.02, 0.03, "9/1 12:00am" },
                        new object[] { "Alcoa Inc", 29.01, 0.42, 1.47, "9/1 12:00am" },
                        new object[] { "Altria Group Inc", 83.81, 0.28, 0.34, "9/1 12:00am" },
                        new object[] { "American Express Company", 52.55, 0.01, 0.02, "9/1 12:00am" },
                        new object[] { "American International Group, Inc.", 64.13, 0.31, 0.49, "9/1 12:00am" },
                        new object[] { "AT&T Inc.", 31.61, -0.48, -1.54, "9/1 12:00am" },
                        new object[] { "Boeing Co.", 75.43, 0.53, 0.71, "9/1 12:00am" },
                        new object[] { "Caterpillar Inc.", 67.27, 0.92, 1.39, "9/1 12:00am" },
                        new object[] { "Citigroup, Inc.", 49.37, 0.02, 0.04, "9/1 12:00am" },
                        new object[] { "E.I. du Pont de Nemours and Company", 40.48, 0.51, 1.28, "9/1 12:00am" },
                        new object[] { "Exxon Mobil Corp", 68.1, -0.43, -0.64, "9/1 12:00am" },
                        new object[] { "General Electric Company", 34.14, -0.08, -0.23, "9/1 12:00am" },
                        new object[] { "General Motors Corporation", 30.27, 1.09, 3.74, "9/1 12:00am" },
                        new object[] { "Hewlett-Packard Co.", 36.53, -0.03, -0.08, "9/1 12:00am" },
                        new object[] { "Honeywell Intl Inc", 38.77, 0.05, 0.13, "9/1 12:00am" },
                        new object[] { "Intel Corporation", 19.88, 0.31, 1.58, "9/1 12:00am" },
                        new object[] { "International Business Machines", 81.41, 0.44, 0.54, "9/1 12:00am" },
                        new object[] { "Johnson & Johnson", 64.72, 0.06, 0.09, "9/1 12:00am" },
                        new object[] { "JP Morgan & Chase & Co", 45.73, 0.07, 0.15, "9/1 12:00am" },
                        new object[] { "McDonald\"s Corporation", 36.76, 0.86, 2.40, "9/1 12:00am" },
                        new object[] { "Merck & Co., Inc.", 40.96, 0.41, 1.01, "9/1 12:00am" },
                        new object[] { "Microsoft Corporation", 25.84, 0.14, 0.54, "9/1 12:00am" },
                        new object[] { "Pfizer Inc", 27.96, 0.4, 1.45, "9/1 12:00am" },
                        new object[] { "The Coca-Cola Company", 45.07, 0.26, 0.58, "9/1 12:00am" },
                        new object[] { "The Home Depot, Inc.", 34.64, 0.35, 1.02, "9/1 12:00am" },
                        new object[] { "The Procter & Gamble Company", 61.91, 0.01, 0.02, "9/1 12:00am" },
                        new object[] { "United Technologies Corporation", 63.26, 0.55, 0.88, "9/1 12:00am" },
                        new object[] { "Verizon Communications", 35.57, 0.39, 1.11, "9/1 12:00am" },
                        new object[] { "Wal-Mart Stores, Inc.", 45.45, 0.73, 1.63, "9/1 12:00am" }
                    };
    
                object[] lstColumnsData = new object[]
                    {
                    // I have changed order of columns here
                        new ColumnsDTO(){ ColumnName="company", Display= true,Locked= false,Order=2 },
                        new ColumnsDTO() { ColumnName="price", Display=true,Locked= false,Order=4 },
                        new ColumnsDTO() { ColumnName="change",Display= true, Locked= false,Order=5 },
                        new ColumnsDTO() { ColumnName="pctChange", Display=true, Locked= false,Order=3 },
                        new ColumnsDTO() { ColumnName="lastChange", Display=true,Locked=  false,Order=1 }                      
                    };
    
                    return new object[] { lstData,lstColumnsData };
            }
        }
    You need to add following reference at the top of the page:
    <script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js"></script>

    Please suggest me how can I insert columns as per order.
  4. #4
    I think there is a logical error in the reorderColumns.

    Please try this one.

    Example
    var reorderColumns = function (store, records) {
        var grid = App.grid,
            columns = grid.getView().getGridColumns(),
            columnToInsert;
    
        grid.removeAllColumns(false);
    
        records.sort(function (a, b) {
            return a.data.Order < b.data.Order ? -1 : 1;
        });
    
        Ext.suspendLayouts(); // to improve performance
    
        Ext.each(records, function (colConfig) {
            columnToInsert = Ext.Array.findBy(columns, function (col) {
                return col.text === colConfig.data.ColumnName;
            });
    
            grid.insertColumn(colConfig.data.Order - 1, columnToInsert, false); // false to improve performance
        });
            
        // manual refreshing because of false passed to the insertColumn call
        grid.updateLayout(); 
        grid.fireEvent('reconfigure', grid); 
        grid.getView().refresh();
    
        Ext.resumeLayouts(true);
    };
  5. #5
    The fix is commited to SVN
  6. #6
    Hi Daniil,

    It's working great.

    Thanks a lot !

Similar Threads

  1. Replies: 11
    Last Post: Apr 04, 2013, 4:49 AM
  2. Replies: 3
    Last Post: Feb 15, 2013, 3:49 AM
  3. Replies: 1
    Last Post: Feb 15, 2013, 3:19 AM
  4. Insert Icon into Column Header of GridPanel
    By sachin.munot in forum 1.x Help
    Replies: 3
    Last Post: Jan 19, 2010, 2:16 PM
  5. [CLOSED] Setting GridPanel column dataindex
    By tansu in forum 1.x Legacy Premium Help
    Replies: 3
    Last Post: May 20, 2009, 3:42 PM

Posting Permissions