[CLOSED] Style changed after upgrade to latest version

  1. #1

    [CLOSED] Style changed after upgrade to latest version

    I upgraded to latest version from trunk this morning and noticed lots of visual error in my app. Do you know what styling change was committed that may affect offsets and such? Below are before and after.

    before
    Click image for larger version. 

Name:	style_before.png 
Views:	91 
Size:	70.0 KB 
ID:	5643

    after
    Click image for larger version. 

Name:	style_after.png 
Views:	93 
Size:	95.1 KB 
ID:	5644

    There is no css change on my end from before to after. It seems like global reset of H1-H6 is gone? along with some weird offsets for divs.
    Last edited by Baidaly; Feb 18, 2013 at 8:18 PM. Reason: [CLOSED]
  2. #2
    Thanks for the report, TabMenu issue is fixed in SVN

    In ExtJS 4.2 RC themes structure was changed and may be some css rules were changed also

    Other issue: as I understood, left widget is DataView therefore you control all required rules for correct representation (may be you need to set zero padding and etc for own elements in the template)
    What is top wiget? I don't thing that it is something standard therefore you should change your css rules

    Or provide test case, we will hapy to help to fix those issues
  3. #3
    Quote Originally Posted by Vladimir View Post
    Thanks for the report, TabMenu issue is fixed in SVN

    In ExtJS 4.2 RC themes structure was changed and may be some css rules were changed also

    Other issue: as I understood, left widget is DataView therefore you control all required rules for correct representation (may be you need to set zero padding and etc for own elements in the template)
    What is top wiget? I don't thing that it is something standard therefore you should change your css rules

    Or provide test case, we will hapy to help to fix those issues
    Thanks, I will update from SVN for tab menu. The left widget is a dataview but I am using the html tpl and similar styles to your dataview examples. I will run the Explorer locally and see if I need to update my css styles. Like I said though, I didn't change any of my css styles prior to this.
  4. #4
    Can Ext.NET reach out to Sencha and ask if they remove the CSS reset that has always been in their styles? I am referring to the reset that removes paddings/margins from all elements.
  5. #5
    This affects Examples Explorer too. I attached before and after of the Advanced DataView example. Note the increased margin between elements, even in your tree on the left hand side.



    Before
    Click image for larger version. 

Name:	style_ext_before.jpg 
Views:	83 
Size:	79.4 KB 
ID:	5646

    After
    Click image for larger version. 

Name:	style_ext_after.jpg 
Views:	56 
Size:	72.5 KB 
ID:	5645
  6. #6
    Ok, I think I fixed most of the places in my application now that css reset is gone. I hope they dont re-add that back later.....
  7. #7
    It seems that ExtJS theme doesn't reset default browser styles anymore
    See in http://www.sencha.com/forum/showthread.php?256443
    EXTJSIV-8383 - Themes should not use resetCSS and related scopeResetCSS and styleHtmlContent
    If you need reset then you can add the following code to head tag
    <style>
            html, body, div, dl, dt, dd, ul, ol, li, h1, h2, h3,
            h4, h5, h6, pre, code, form, fieldset, legend,
            input, textarea, p, blockquote, th, td {
              margin: 0;
              padding: 0; } 
        </style>
        <ext:ResourcePlaceHolder runat="server" Mode="Style" />
  8. #8
    Ok cool. Thanks for looking into it. Please mark this as closed. Looking forward to seeing the new Neptune theme.

Similar Threads

  1. [CLOSED] Portal example in latest version
    By HansWapenaar in forum 2.x Legacy Premium Help
    Replies: 5
    Last Post: Jan 04, 2013, 7:51 AM
  2. Replies: 2
    Last Post: Feb 03, 2011, 4:19 PM
  3. [CLOSED] [1.0] Latest version
    By rthiney in forum 1.x Legacy Premium Help
    Replies: 2
    Last Post: Jul 20, 2010, 6:04 PM
  4. [CLOSED] store always databinding in latest version
    By alexp in forum 1.x Legacy Premium Help
    Replies: 1
    Last Post: Aug 07, 2009, 4:29 PM
  5. [CLOSED] Upgrade from v0.7 to latest with errors
    By jchau in forum 1.x Legacy Premium Help
    Replies: 6
    Last Post: Feb 13, 2009, 6:51 PM

Posting Permissions