[1.0] CustomConfig produces error

[nextSTEP]

Hallo,

I covered a bug where invalid JS is generated. If you specify a ConfigItem with an empty value (String.Empty), JS misses a semicolon.

Steps to reproduce:
- Place a Grid Panel onto an empty web page.
- Insert code behind:

protected void Page_Load(object sender, EventArgs e)
{
    this.GridPanel1.Store.Add(new Store());

    Column column = new Column();
    column.ColumnID = "Column 1";
    column.CustomConfig.Add(new ConfigItem("Test", ""));

    this.GridPanel1.ColumnModel.Columns.Add(column);
}

[Vladimir]

Hi,

It is not bug. You have to use ParameterMode.Value in your case

column.CustomConfig.Add(new ConfigItem("Test", "", ParameterMode.Value));

[nextSTEP]

Yes maybe, but why is the generated JS this:

{ Key : "test", Value : }

shouldn't it be Value : undefined or something, regardless which ParameterMode is set.

[Vladimir]

Hi,

Default mode for CustomConfig is Raw, it means that the value will be rendered as is (as you provided, no transformation).
Value mode means that the value will be wrapped by quotes

[geoffrey.mcgill]

We're looking into this. I agree that script should not render with a syntax error.

In this case, probably should render as : "", even if Mode is Raw.