[FIXED] [#659] MultiUpload unhandled exception when hover over "Browse..." button (SVN 6281)

Printable View

Show 40 post(s) from this thread on one page

Jan 27, 2015, 9:35 AM
matt

1 Attachment(s)

[FIXED] [#659] MultiUpload unhandled exception when hover over "Browse..." button (SVN 6281)

Hi,

In the example https://examples3.ext.net/Examples/M...ad/Basic/Grid/ when you hover mouse cursor over the Browse button, unhanded exception is thrown.

http://forums.ext.net/attachment.php...id=19521&stc=1

The exception is thrown in function "is" of Ext.dom.Element.

Code:

is: function(selector) { var dom = this.dom, is; if (!selector) { is = true; } else if (!dom.tagName) { is = false; } else if (Ext.isFunction(selector)) { is = selector(dom); } else { // EXCEPTION IS THROWN HERE... is = dom[Ext.supports.matchesSelector](selector); } return is; }

Below is my workaround for this problem but I think it might not be the real nature of the problem.

Code:

Ext.define("App.Patches.dom.Element", { override: 'Ext.dom.Element', is: function (selector) { var dom = this.dom, is; if (!selector) { is = true; } else if (!dom.tagName) { is = false; } else if (Ext.isFunction(selector)) { is = selector(dom); } else { // WORKAROUND / FIX if (dom[Ext.supports.matchesSelector]) { is = dom[Ext.supports.matchesSelector](selector); } else { is = false; } } return is; } });
Jan 27, 2015, 12:11 PM
Daniil

Hi Matt,

Thank you for the report.

Your workaround is good enough for now to move on, but the real problem is that IE seems don't support .msMatchesSelector() for an <object>. At least, for a Flash <object>. I am looking for a way to check an <object> on selector. I will check jQuery. Maybe, this problem is solved there.
Jan 28, 2015, 8:16 AM
Daniil

Created an Issue.
https://github.com/extnet/Ext.NET/issues/659

Yes, jQuery helped to fix the defect. Committed the fix in the revision #6282. It goes to 3.1.0 beta release.
Jan 29, 2015, 2:55 PM
matt

Thank you

I confirm. It is working fine now.
Mar 02, 2015, 6:28 AM
Daniil

Hi Matt,

For some reason we've removed the fix from SVN. Maybe, it was removed by mistake, but it is another story. Currently, I am trying to reproduce the original issue and somehow I cannot reproduce it. Could you, please, do a favor updating from SVN trunk and retest the issue? Is it reproducible or not for you?
Mar 02, 2015, 9:25 AM
matt

Hi Danill,

Yes, the problem is reproducible in latest SVN. Thank you for letting me know... for the time being I will patch it again.
Mar 02, 2015, 9:40 AM
Daniil

Thank you for a quick answer. I cannot understand why I cannot reproduce it on my side. After your initial bug report I reproduced it easily with just this test case. Can you reproduce it with this test case?

Also my environment is still the same - Windows 7 and IE 10. Maybe, some recent Windows Update fixed it... Do you have all the Windows Updates installed currently? Only IE 11 is not installed for me. But again, I was able to reproduce it easily with IE 10.

Example

Code:

<%@ Page Language="C#" %> <!DOCTYPE html> <html> <head runat="server"> <title>Ext.NET v3 Example</title> </head> <body> <form runat="server"> <ext:ResourceManager runat="server" /> <ext:MultiUpload runat="server" /> </form> </body> </html>
Mar 02, 2015, 9:56 AM
matt

2 Attachment(s)

Hi Danill,

There is one more "odd" thing going on right now. I am trying to apply the patch. It does override "is" method but it doesn't fix the problem now. For some reason the non-overridden "is" is called.

Have a look at the stack trace...

In both cases the patch is applied and item selector in findParent is the same: #pv_pltUpload .x-resizable-handle

Case 1: the patch version is called

Attachment 21971

Case 2: original version is called (so patch doesn't help here)

Attachment 21972

Hope this will help. I will try to carve out simple version of my code and post it here...

Best,
Mar 02, 2015, 1:08 PM
Daniil

I would also expect the original .is() should not be called. Yeah, I would love to investigate a test case.
Mar 02, 2015, 1:17 PM
matt

Danill,

I've got prebeta-release tomorrow. Can you tell me in which version it was removed so I can go back to the previous ?
I will try to prepare test case now.

Thank you,

Show 40 post(s) from this thread on one page