[OPEN] [#330] A suggestion to eradicate "Token is not unique" errors
Code:
Token is not unique
-------------------
ID = ctl00_cp_TaskUC0_TDatesW_ClientInit
TagName = anchor
Match = <#:anchor id="ctl00_cp_TaskUC0_TDatesW_ClientInit" />
I don't know if this would be considered a bug, but I was tracking the occurrence of this issue within my code. It took a good number of hours but I finally realized it was because I was adding the same user control twice. Effectively to reproduce, all you need to do is the following:
Code:
Panel1.Items.Add( ctl ); Panel1.Items.Add( ctl );
Code:
Panel1.Bin.Add( ctl ); Panel1.Bin.Add( ctl );
Here's my reason for posting this. It seems to me that I had to work all the way backwards from Transformer which is very late way to discover the issue. It's not excepting out where the issue actually happens, and its easy to catch.
I looked at ItemsCollection<T> which is derived from List<T> and though I thought HashSet might be better, I tried it but there's a lot of dependencies on functions of IList and performance was unnecessary to affect Release versions, so instead I thought it would be easy to add the following so I tried:
Code:
new public void Add(T item)
{
#if DEBUG
if(base.Contains(item))
throw new Exception("Duplicate control");
#endif
this.CheckItem(item);
if (this.BeforeItemAdd != null)
{
this.BeforeItemAdd(item);
}
base.Add(item);
if (this.AfterItemAdd != null)
{
this.AfterItemAdd(item);
}
}
It worked. Now you just need to apply the same tests for AddRange and Insert and this problem saves another programmer some grief.
