PDA

View Full Version : [FIXED] [V0.7] Sizing bug for buttons in tabpanel



Jurke
Oct 29, 2008, 2:22 PM
Hi
I noticed a bug, when buttons are placed in a tabpanel in any tab but the first one, the sizing gets wrong. The size for the buttons in tab 2 and 3 gets far to big. Look at this sample code




<html xmlns="http://www.w3.org/1999/xhtml">
<head id="Head1" runat="server">
<title></title>
</head>
<body>
<form id="form2" runat="server">
<ext:ScriptManager ID="ScriptManager2" runat="server" HideInDesign="false">
</ext:ScriptManager>
<ext:TabPanel ID="tabpnlMain" runat="server" Width="300">
<Tabs>
<ext:Tab ID="tab1" runat="server" Title="Tab1" >
<Body>
<ext:Button ID="Button1" runat="server" Text="XXXXXXXXXXXXXXXXXXXXXXXXXXX">
</ext:Button>
</Body>
</ext:Tab>
<ext:Tab ID="tab2" runat="server" Title="Tab2" >
<Body>
<ext:Button ID="Button2" runat="server" Text="XXXXXXXXXXXXXXXXXXXXXXXXXXX">
</ext:Button>
</Body>
</ext:Tab>
<ext:Tab ID="tab3" runat="server" Title="Tab3" >
<Body>
<ext:Button ID="Button3" runat="server" Text="XXXXXXXXXXXXXXXXXXXXXXXXXXX">
</ext:Button>
</Body>
</ext:Tab>
</Tabs>
</ext:TabPanel>
</form>
</body>
</html>


Best regards
Mikael Jürke

Vladimir
Oct 30, 2008, 8:45 AM
Hi Mikael,

This bug was fixed and committed to SVN

Jurke
Oct 30, 2008, 8:58 AM
Thank you!

Jurke
Oct 30, 2008, 9:47 AM
New follow up bug, probably as result of last fix. Size on buttons gets to small when an Iframe is used, as before only in tabs != first tab.
See example.


Test.aspx





<html xmlns="http://www.w3.org/1999/xhtml">


<head id="Head1" runat="server">





<title>Test</title>





</head>


<body>


<form id="form1" runat="server">





<ext:ScriptManager ID="ScriptManager1" runat="server" HideInDesign="false">


</ext:ScriptManager>








<ext:TabPanel ID="Tabanel" runat="server" >


<Tabs>








<ext:Tab ID="Tab2" AutoLoadIFrame="Test2.aspx" runat="server" Title="" >


<Body>


</Body>


</ext:Tab>


<ext:Tab ID="Tab1" AutoLoadIFrame="Test2.aspx" runat="server" Title="" >


<Body>


</Body>


</ext:Tab>





</Tabs>


</ext:TabPanel>





</form>





</body>


</html>


Test2.aspx





<html xmlns="http://www.w3.org/1999/xhtml">


<head runat="server">


<title>Untitled Page</title>


</head>


<body>


<form id="form1" runat="server">








<ext:ScriptManager ID="ScriptManager1" runat="server" HideInDesign="false" />


<ext:Button ID="btnTest" runat="server" Text="Browse" Icon="Magnifier">


</ext:Button>






</form>


</body>


</html>





Best regards
Mikael Jürke

geoffrey.mcgill
Oct 30, 2008, 10:49 AM
Hi Mikael,

I made a css revision which appears to have fixed the problem. I've tested in XHTML Quirks, Transitional and Strict mode in IE, FF and Chrome. Each browser DOCTYPE combo seems to work properly with tests I created and the samples you posted above, although more testing is required to confirm. 


Please SVN update and post a confirmation whether it's now working for you or not. 


I also added the Cache Buster to all embedded .css files. Previously to the latest commit, the buster was only applied to JavaScript (.js) files. The .css should also not cache when the .dll is updated/rebuilt.


Hope this helps.

Jurke
Oct 30, 2008, 10:53 AM
Hi
Thanks! it now works excellent!

Best regards
Mikael Jürke

geoffrey.mcgill
Oct 30, 2008, 11:01 AM
The latest fix introduces an <ext:Button> rendering bug in Visual Studio Design mode. I'm working on a fix. 

Runtime browser rendering still appears to work great. 

Jurke
Oct 30, 2008, 11:07 AM
Ok thanks for the info.

/Mikael

geoffrey.mcgill
Oct 30, 2008, 12:26 PM
Ok, a <ext:Button> Designer fix for Visual Studio has been committed. Hopefully we can finally close the case on this one. 

Please let us know if you find any further <ext:Button> sizing issues. I still have a few more tests I'd like to run and will post an update if I we make any more changes.