PDA

View Full Version : [CLOSED] CSS border disappears in multiple rows column headers for the last sub-header



bogc
Nov 07, 2014, 12:51 AM
Hi:

This is a weird one. To reproduce please run the code below. Pay attention to the 'Change %' right border. If you are quick you'll notice that the black right border will appear and disappear quickly.



<%@ Page Language="C#" %>

<%@ Register Assembly="Ext.Net" Namespace="Ext.Net" TagPrefix="ext" %>

<script runat="server">
protected void Page_Load(object sender, EventArgs e)
{
if (!X.IsAjaxRequest)
{
this.Store1.DataSource = this.Data;
this.Store1.DataBind();
}
}

private object[] Data
{
get
{
return new object[]
{
new object[] { "3m Co", 71.72, 0.02, 0.03, "9/1 12:00am" },
new object[] { "Alcoa Inc", 29.01, 0.42, 1.47, "9/1 12:00am" },
new object[] { "Altria Group Inc", 83.81, 0.28, 0.34, "9/1 12:00am" },
new object[] { "American Express Company", 52.55, 0.01, 0.02, "9/1 12:00am" },
new object[] { "American International Group, Inc.", 64.13, 0.31, 0.49, "9/1 12:00am" },
new object[] { "AT&T Inc.", 31.61, -0.48, -1.54, "9/1 12:00am" },
new object[] { "Boeing Co.", 75.43, 0.53, 0.71, "9/1 12:00am" },
new object[] { "Caterpillar Inc.", 67.27, 0.92, 1.39, "9/1 12:00am" },
new object[] { "Citigroup, Inc.", 49.37, 0.02, 0.04, "9/1 12:00am" },
new object[] { "E.I. du Pont de Nemours and Company", 40.48, 0.51, 1.28, "9/1 12:00am" },
new object[] { "Exxon Mobil Corp", 68.1, -0.43, -0.64, "9/1 12:00am" },
new object[] { "General Electric Company", 34.14, -0.08, -0.23, "9/1 12:00am" },
new object[] { "General Motors Corporation", 30.27, 1.09, 3.74, "9/1 12:00am" },
new object[] { "Hewlett-Packard Co.", 36.53, -0.03, -0.08, "9/1 12:00am" },
new object[] { "Honeywell Intl Inc", 38.77, 0.05, 0.13, "9/1 12:00am" },
new object[] { "Intel Corporation", 19.88, 0.31, 1.58, "9/1 12:00am" },
new object[] { "International Business Machines", 81.41, 0.44, 0.54, "9/1 12:00am" },
new object[] { "Johnson & Johnson", 64.72, 0.06, 0.09, "9/1 12:00am" },
new object[] { "JP Morgan & Chase & Co", 45.73, 0.07, 0.15, "9/1 12:00am" },
new object[] { "McDonald\"s Corporation", 36.76, 0.86, 2.40, "9/1 12:00am" },
new object[] { "Merck & Co., Inc.", 40.96, 0.41, 1.01, "9/1 12:00am" },
new object[] { "Microsoft Corporation", 25.84, 0.14, 0.54, "9/1 12:00am" },
new object[] { "Pfizer Inc", 27.96, 0.4, 1.45, "9/1 12:00am" },
new object[] { "The Coca-Cola Company", 45.07, 0.26, 0.58, "9/1 12:00am" },
new object[] { "The Home Depot, Inc.", 34.64, 0.35, 1.02, "9/1 12:00am" },
new object[] { "The Procter & Gamble Company", 61.91, 0.01, 0.02, "9/1 12:00am" },
new object[] { "United Technologies Corporation", 63.26, 0.55, 0.88, "9/1 12:00am" },
new object[] { "Verizon Communications", 35.57, 0.39, 1.11, "9/1 12:00am" },
new object[] { "Wal-Mart Stores, Inc.", 45.45, 0.73, 1.63, "9/1 12:00am" }
};
}
}
</script>

<!DOCTYPE html>

<html>
<head runat="server">
<title>Grouped Header Example - Ext.NET Examples</title>
<link href="/resources/css/examples.css" rel="stylesheet" />

<style>
/* style rows on mouseover */
.x-grid-row-over .x-grid-cell-inner {
font-weight: bold;
}
#CompanyColumn-titleEl {
border-right: 1px solid black;
}

#ChangeColumn-titleEl {
border-right: 1px solid black;
}

#ChangeColumnPrc-titleEl {
border-right: 1px solid black;
}

#LastUpdated-titleEl {
border-right: 1px solid black;
}

</style>

<script>


var template = '<span style="color:{0};">{1}</span>';

var change = function (value) {
return Ext.String.format(template, (value > 0) ? "green" : "red", value);
};

var pctChange = function (value) {
return Ext.String.format(template, (value > 0) ? "green" : "red", value + "%");
};
</script>

</head>
<body>
<ext:ResourceManager runat="server" />

<h1>Grouped Header Example</h1>
<p>This example shows how to create a grid with column headers which are nested within category headers.</p>
<p>Category headers do not reference Model fields via a <code>dataIndex</code>, rather they contain
child header definitions (which may themselves either contain a <code>dataIndex</code> or more levels of headers).</p>


<ext:GridPanel
ID="GridPanel1"
runat="server"
Title="Grouped Header Grid"
Width="600"
ColumnLines="true"
Border="false"
EnableColumnMove="false"
EnableColumnHide="false"
SelectionMemory="False"
Height="350">
<SelectionModel>
<ext:CellSelectionModel runat="Server"/>
</SelectionModel>
<Store>
<ext:Store ID="Store1" runat="server">
<Model>
<ext:Model runat="server">
<Fields>
<ext:ModelField Name="company" />
<ext:ModelField Name="price" Type="Float" />
<ext:ModelField Name="change" Type="Float" />
<ext:ModelField Name="pctChange" Type="Float" />
<ext:ModelField Name="lastChange" Type="Date" DateFormat="M/d hh:mmtt" />
</Fields>
</ext:Model>
</Model>
</ext:Store>
</Store>
<ColumnModel runat="server">
<Columns>
<ext:Column ID = "CompanyColumn" runat="server" Text="Company" DataIndex="company" Flex="1" Sortable="false" />

<ext:Column runat="server" Text="Stock Price">
<Columns>
<ext:Column runat="server" Text="Price" DataIndex="price" Width="75" Sortable="true">
<Renderer Format="UsMoney" />
</ext:Column>
<ext:Column ID="ChangeColumn" runat="server" Text="Change" DataIndex="change" Width="75" Sortable="true">
<Renderer Fn="change" />
</ext:Column>
<ext:Column ID="ChangeColumnPrc" runat="server" Text="Change %" DataIndex="pctChange" Width="75" Sortable="true">
<Renderer Fn="pctChange" />
</ext:Column>
</Columns>
</ext:Column>

<ext:DateColumn ID="LastUpdated" runat="server" Text="Last Updated" DataIndex="lastChange" Width="85" Sortable="true" Format="dd/MM/yyyy" />
</Columns>
</ColumnModel>
<View>
<ext:GridView runat="server" DeferInitialRefresh="True"></ext:GridView>
</View>
</ext:GridPanel>

</body>
</html>



It turns out that the border is turned off by this function, line 16. It occurs only for the last column in a group.

src\grid\ColumnComponentLayout.js:


beginLayoutCycle: function(ownerContext) {
var me = this,
owner = me.owner;

me.callParent(arguments);

// If shrinkwrapping, allow content width to stretch the element
if (ownerContext.widthModel.shrinkWrap) {
owner.el.setWidth('');
}

// When we are the last subheader, bordering is provided by our owning header, so we need
// to set border width to zero
var borderRightWidth = owner.isLast && owner.isSubHeader ? '0' : '';
if (borderRightWidth !== me.lastBorderRightWidth) {
owner.el.dom.style.borderRightWidth = me.lasBorderRightWidth = borderRightWidth;
}

owner.titleEl.setStyle({
paddingTop: '', // reset back to default padding of the style
paddingBottom: ''
});
},


This issue didn't occur in the Ext.Net 2.2.1/ExtJs 4.1.1. There is significantly more code in the ExtJs 4.2.3 version of this class than it is in 4.1.1.

Any idea on how to fix it?

I could simply override the function and remove the setting but I am not too sure about the side effects of doing so. I guess I'll have to try.

Thanks!

Update 1: It turns out I was wrong. even if override the method and I comment out line 16 the border still disappears. I will see what I find...
Update 2: This does the trick. Note that I replaced me.callParent(arguments) with me.callSuper(arguments). me.callParent(arguments) was calling the old function which I wanted to avoid calling.



Ext.grid.ColumnComponentLayout.override({

beginLayoutCycle: function (ownerContext) {
var me = this,
owner = me.owner;

me.callSuper(arguments);

// If shrinkwrapping, allow content width to stretch the element
if (ownerContext.widthModel.shrinkWrap) {
owner.el.setWidth('');
}

// When we are the last subheader, bordering is provided by our owning header, so we need
// to set border width to zero
var borderRightWidth = owner.isLast && owner.isSubHeader ? '0' : '';
if (borderRightWidth !== me.lastBorderRightWidth)
{
//debugger;
//owner.el.dom.style.borderRightWidth = me.lasBorderRightWidth = borderRightWidth;
}
owner.titleEl.setStyle({
paddingTop: '', // reset back to default padding of the style
paddingBottom: ''
});
}
});

Daniil
Nov 10, 2014, 5:34 AM
Hi @bogc,

Apologize for the delay in answering.

That is an explanation why they reset the right border width.

// When we are the last subheader, bordering is provided by our owning header, so we need
// to set border width to zero

Probably, that is correct, but they didn't take into account that someone can provide custom styling for that, as you do.

I think your solution is good.