[FIXED] [#524] [#528] Item isn't highlighted in MultiCombo

**Daniil** · Jul 16, 2014, 4:45 PM

.initSelection() appears to accept a single value, does it not?

It can take multiple items.

combo.initSelection([{
    value: 1
}, {
    value: 2
}]);

**vadym.f** · Jul 16, 2014, 5:46 PM

Got it, thanks. As a side note, I've noticed that two clearing calls appear necessary in order to select the items on the server cleanly:

        MultiCombo1.Clear();
        MultiCombo1.SelectedItems.Clear();

        MultiCombo1.SelectedItems.Add(new Ext.Net.SelectedListItem { Value = "1" });
        MultiCombo1.SelectedItems.Add(new Ext.Net.SelectedListItem { Value = "2" });
        MultiCombo1.UpdateSelection();

If I drop either one or both of them, I get problems with highlighting or item appendment instead of addition (the latter makes sense).

It would be nice if .UpdateSelection() were called seamlessly within the context of the .SelectedItems.Add() execution - maybe, later frameworks take care of that.
Overall, I'm content with the workarounds and fixes here.

**Daniil** · Jul 17, 2014, 4:41 PM

If I drop either one or both of them, I get problems with highlighting or item appendment instead of addition (the latter makes sense).

Only this

MultiCombo1.SelectedItems.Clear();

should be required, because a SelectedItems collection takes actual selection from POST.

As for this

MultiCombo1.Clear();

I think it should not be required and it appears to be working well for me without that call. If you have time to provide me with a test case and describe exact steps, I could look at.

It would be nice if .UpdateSelection() were called seamlessly within the context of the .SelectedItems.Add() execution - maybe, later frameworks take care of that.

Do you mean to call .UpdateSelection() implicitly if a developer changes a SelectedItems collection?

**vadym.f** · Jul 17, 2014, 10:12 PM

It seems to me that the culprit of my issue is data-binding of the Store within a direct method. To reproduce, select the last two items in the combo (test3 and test4) and click on the "Select Items" button. Notice that the previous two items are still selected although seemingly not on display. If you un-comment the MultiCombo1.Clear(); call, the issue can't be reproduced.

<%@ Page Language="C#" %>

<%@ Register Assembly="Ext.Net" Namespace="Ext.Net" TagPrefix="ext" %>
<script runat="server">
    protected void Page_Load(object sender, EventArgs e)
    {
        if (!X.IsAjaxRequest)
        {
            Store1.DataSource = new object[]
            {
                new object[] { 1, "test1" },
                new object[] { 2, "test2" },
                new object[] { 3, "test3" },
                new object[] { 4, "test4" }
            };
            Store1.DataBind();
        }
    }

    [DirectMethod]
    public void SelectRecordServer()
    {
        Store1.DataSource = new object[]
            {
                new object[] { 1, "test1" },
                new object[] { 2, "test2" },
                new object[] { 3, "test3" },
                new object[] { 4, "test4" }
            };
        Store1.DataBind();
        
        //MultiCombo1.Clear();
        MultiCombo1.SelectedItems.Clear();
        MultiCombo1.SelectedItems.Add(new Ext.Net.SelectedListItem { Value = "1" });
        MultiCombo1.SelectedItems.Add(new Ext.Net.SelectedListItem { Value = "2" });
        MultiCombo1.UpdateSelection();
    }
</script>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head id="Head1" runat="server">
    <title>Ext.NET Example</title>
    <ext:ResourcePlaceHolder ID="ResourcePlaceHolder1" runat="server" Mode="Script" />
    <ext:ResourcePlaceHolder ID="ResourcePlaceHolder2" runat="server" Mode="Style" />

    <script type="text/javascript">
        var selectRecordServer = function () {
            try {
                X.SelectRecordServer({
                    eventMask: { showMask: true },
                    success: function () {
                    }
                });
            } catch (e) {

            }
        };
    </script>
</head>
<body>
    <form id="Form1" runat="server">
        <ext:ResourceManager ID="ResourceManager1" runat="server" DirectMethodNamespace="X" />
        <ext:FormPanel runat="server" Width="400">
            <Items>
                <ext:MultiCombo ID="MultiCombo1" runat="server" Width="260" DisplayField="Description" ValueField="ID" EnableKeyEvents="true" Delimiter=";" SelectionMode="All" Mode="Local"
                    SelectOnFocus="true" FieldLabel="Items" EmptyText="Select Items...">
                    <Store>
                        <ext:Store ID="Store1" AutoLoad="true" runat="server">
                            <Reader>
                                <ext:ArrayReader IDProperty="ID">
                                    <Fields>
                                        <ext:RecordField Name="ID" />
                                        <ext:RecordField Name="Description" />
                                    </Fields>
                                </ext:ArrayReader>
                            </Reader>
                        </ext:Store>
                    </Store>
                </ext:MultiCombo>
            </Items>
            <BottomBar>
                <ext:Toolbar runat="server">
                    <Items>
                        <ext:Button runat="server" Text="Select Item (Server)">
                            <Listeners>
                                <Click Fn="selectRecordServer" />
                            </Listeners>
                        </ext:Button>
                    </Items>
                </ext:Toolbar>
            </BottomBar>
        </ext:FormPanel>
    </form>
</body>
</html>

**vadym.f** · Jul 17, 2014, 10:12 PM

It seems to me that the culprit of my issue is data-binding of the Store within a direct method. To reproduce, select the last two items in the combo (test3 and test4) and click on the "Select Items" button. Notice that the previous two items are still selected although seemingly not on display. If you un-comment the MultiCombo1.Clear(); call, the issue can't be reproduced.

<%@ Page Language="C#" %>

<%@ Register Assembly="Ext.Net" Namespace="Ext.Net" TagPrefix="ext" %>
<script runat="server">
    protected void Page_Load(object sender, EventArgs e)
    {
        if (!X.IsAjaxRequest)
        {
            Store1.DataSource = new object[]
            {
                new object[] { 1, "test1" },
                new object[] { 2, "test2" },
                new object[] { 3, "test3" },
                new object[] { 4, "test4" }
            };
            Store1.DataBind();
        }
    }

    [DirectMethod]
    public void SelectRecordServer()
    {
        Store1.DataSource = new object[]
            {
                new object[] { 1, "test1" },
                new object[] { 2, "test2" },
                new object[] { 3, "test3" },
                new object[] { 4, "test4" }
            };
        Store1.DataBind();
        
        //MultiCombo1.Clear();
        MultiCombo1.SelectedItems.Clear();
        MultiCombo1.SelectedItems.Add(new Ext.Net.SelectedListItem { Value = "1" });
        MultiCombo1.SelectedItems.Add(new Ext.Net.SelectedListItem { Value = "2" });
        MultiCombo1.UpdateSelection();
    }
</script>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head id="Head1" runat="server">
    <title>Ext.NET Example</title>
    <ext:ResourcePlaceHolder ID="ResourcePlaceHolder1" runat="server" Mode="Script" />
    <ext:ResourcePlaceHolder ID="ResourcePlaceHolder2" runat="server" Mode="Style" />

    <script type="text/javascript">
        var selectRecordServer = function () {
            try {
                X.SelectRecordServer({
                    eventMask: { showMask: true },
                    success: function () {
                    }
                });
            } catch (e) {

            }
        };
    </script>
</head>
<body>
    <form id="Form1" runat="server">
        <ext:ResourceManager ID="ResourceManager1" runat="server" DirectMethodNamespace="X" />
        <ext:FormPanel runat="server" Width="400">
            <Items>
                <ext:MultiCombo ID="MultiCombo1" runat="server" Width="260" DisplayField="Description" ValueField="ID" EnableKeyEvents="true" Delimiter=";" SelectionMode="All" Mode="Local"
                    SelectOnFocus="true" FieldLabel="Items" EmptyText="Select Items...">
                    <Store>
                        <ext:Store ID="Store1" AutoLoad="true" runat="server">
                            <Reader>
                                <ext:ArrayReader IDProperty="ID">
                                    <Fields>
                                        <ext:RecordField Name="ID" />
                                        <ext:RecordField Name="Description" />
                                    </Fields>
                                </ext:ArrayReader>
                            </Reader>
                        </ext:Store>
                    </Store>
                </ext:MultiCombo>
            </Items>
            <BottomBar>
                <ext:Toolbar runat="server">
                    <Items>
                        <ext:Button runat="server" Text="Select Items">
                            <Listeners>
                                <Click Fn="selectRecordServer" />
                            </Listeners>
                        </ext:Button>
                    </Items>
                </ext:Toolbar>
            </BottomBar>
        </ext:FormPanel>
    </form>
</body>
</html>

**Daniil** · Jul 19, 2014, 6:59 AM

Thank you for the test case. It appears that it behaves the same in Ext.NET v2. I will investigate.

For now, let's say a .Clear() call is required:)

**Daniil** · Jul 21, 2014, 3:00 PM

Created an Issue.
https://github.com/extnet/Ext.NET/issues/528

Fixed in SVN.

v1: revision #5918
v2: revision #5916

Now updating of selection clears previous selection first.

Please note that a .SelectedItems.Clear() call is still required.

**vadym.f** · Jul 21, 2014, 5:26 PM

Confirmed, thanks! I'm assuming the call to .UpdateSelection(); is still necessary because it's not working without it.

**Daniil** · Jul 22, 2014, 11:49 AM

Yes, I didn't work on that:) Sorry for misleading you.

An .UpdateSelection() call is still required. It might be quite complicated to get rid of that.

Thread: [FIXED] [#524] [#528] Item isn't highlighted in MultiCombo

Thread Tools

Search Thread

Display

Similar Threads

[CLOSED] Ext.Net.MultiCombo list hides after tapping on the list item on touch devices.

How to get Multicombo Selecting item as Parementer in Direct Event...not selecting items..only selecting item..

[CLOSED] storeItem (the currently highlighted item) for charttips

[CLOSED] Multicombo Item format showing error while checking selected items

MultiCombo with Paging lost selected items when select an item in a new page

Posting Permissions

Sitemap

Downloads

Resources